Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pick avatar from files + use modal #1024

Merged
merged 3 commits into from
Mar 29, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 29, 2019

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Mar 29, 2019
@skjnldsv skjnldsv added this to the next minor milestone Mar 29, 2019
@skjnldsv skjnldsv self-assigned this Mar 29, 2019
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enhancement/avatar/modal+pick-from-files branch from a9a1e4d to 4f4b04b Compare March 29, 2019 10:52
@codecov
Copy link

codecov bot commented Mar 29, 2019

Codecov Report

Merging #1024 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1024   +/-   ##
======================================
  Coverage      60%     60%           
======================================
  Files           4       4           
  Lines          60      60           
======================================
  Hits           36      36           
  Misses         24      24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0444744...4f4b04b. Read the comment docs.

@skjnldsv skjnldsv requested a review from jancborchardt March 29, 2019 11:25
@skjnldsv skjnldsv merged commit 68d5c51 into master Mar 29, 2019
@skjnldsv skjnldsv deleted the enhancement/avatar/modal+pick-from-files branch March 29, 2019 12:44
@skjnldsv skjnldsv modified the milestones: next minor, 3.1.0 Apr 8, 2019
@jancborchardt
Copy link
Member

@skjnldsv this one was hiding somewhere :D sorry for late reply:

  • Loooks soooo great! Much better than the icons without labels we had before. You rock!
  • The popovers should be centered (for the one in the viewer, should be to the right as far as possible with some whitespace, just like the user dropdown is). :) The left-alignment looks strange. ;)

@skjnldsv
Copy link
Member Author

@jancborchardt I think I remember, but did we not wanted to actually set the popover to center as default? 🤔

@jancborchardt
Copy link
Member

@skjnldsv yes, you’re right! It definitely also seems that one of my most given feedbacks on popovers were to center them. :D So seems a good call to make that default.

@skjnldsv
Copy link
Member Author

Let's do that on the components then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow assignment of images already in Nextcloud as contact photos
2 participants