-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pick avatar from files + use modal #1024
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
a9a1e4d
to
4f4b04b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
======================================
Coverage 60% 60%
======================================
Files 4 4
Lines 60 60
======================================
Hits 36 36
Misses 24 24 Continue to review full report at Codecov.
|
@skjnldsv this one was hiding somewhere :D sorry for late reply:
|
@jancborchardt I think I remember, but did we not wanted to actually set the popover to center as default? 🤔 |
@skjnldsv yes, you’re right! It definitely also seems that one of my most given feedbacks on popovers were to center them. :D So seems a good call to make that default. |
Let's do that on the components then :) |
Fix #106
@jancborchardt