Avoid qrcode getting cropped #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase image width for better scanning remove height to avoid white padding over and under qrcode (modal box uses the height for content size, but css resize gets ignored)
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
======================================
Coverage 60% 60%
======================================
Files 4 4
Lines 60 60
======================================
Hits 36 36
Misses 24 24Continue to review full report at Codecov.
|
skjnldsv
approved these changes
Apr 10, 2019
|
Thanks for all you've been doing lately @rponline 🤗 |
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase image width for better scanning
remove height to avoid white padding over and under qrcode
(modal box uses the height for content size, but css resize gets ignored)