Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/allow year removal #1248

Merged
merged 4 commits into from
Sep 3, 2019
Merged

Enhancement/allow year removal #1248

merged 4 commits into from
Sep 3, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 3, 2019

Fix #161
Fix #625

@skjnldsv skjnldsv added enhancement New feature or request 3. to review Waiting for reviews labels Sep 3, 2019
@skjnldsv skjnldsv added this to the next minor milestone Sep 3, 2019
@skjnldsv skjnldsv self-assigned this Sep 3, 2019
ChristophWurst
ChristophWurst requested changes Sep 3, 2019
View reviewed changes
src/components/Actions/ActionCopyNtoFN.vue Outdated Show resolved Hide resolved
src/components/Actions/ActionToggleYear.vue Outdated Show resolved Hide resolved
src/components/Actions/ActionToggleYear.vue Outdated Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the enhancement/allow-year-removal branch from b957150 to 5639895 Compare September 3, 2019 13:01
@skjnldsv
Fix actions design
6220204 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Better debug logs on parsing failure
88510f7 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Allow to toggle year
5a1b111 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Use checkbox for omit year action
2851043 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enhancement/allow-year-removal branch from 2a5f2f0 to 2851043 Compare September 3, 2019 13:42
@codecov
Copy link

codecov bot commented Sep 3, 2019 •
edited
Loading

Codecov Report

Merging #1248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1248   +/-   ##
======================================
  Coverage      60%     60%           
======================================
  Files           4       4           
  Lines          60      60           
======================================
  Hits           36      36           
  Misses         24      24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1caeb...2851043. Read the comment docs.

@skjnldsv skjnldsv merged commit feff0c7 into master Sep 3, 2019
@skjnldsv skjnldsv deleted the enhancement/allow-year-removal branch September 3, 2019 13:56
@skjnldsv skjnldsv modified the milestones: next minor, 3.1.4 Sep 4, 2019
@levfa levfa mentioned this pull request Jan 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst requested changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
3.1.4
Development

Successfully merging this pull request may close these issues.

Allow to set a date without a year several problems with birthday without a year
2 participants
@skjnldsv @ChristophWurst