Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short company field only if empty #1412

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Conversation

myrho
Copy link
Contributor

@myrho myrho commented Jan 16, 2020

Long company names were chopped off way to much. This fixes this while avoiding spread input fields when org field is empty.

@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #1412 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1412   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files           4        4           
  Lines          69       69           
=======================================
  Hits           43       43           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 908607a...3a419cb. Read the comment docs.

@skjnldsv skjnldsv added 3. to review Waiting for reviews design Related to the design labels Jan 16, 2020
@skjnldsv
Copy link
Member

Hey! :)
Welcome :)
Could you provide screenshots as well so that others can review a bit better?

@myrho
Copy link
Contributor Author

myrho commented Jan 16, 2020

Before this pull request:

Before editing:
image

After editing:

image

After this pull request:

Before editing:
image

After editing:

image

@jancborchardt
Copy link
Member

Looks like a good fix, thanks @myrho! :) Note that this might become obsolete though if we do go ahead with the proposal at #1376 (comment)

@skjnldsv skjnldsv merged commit e675751 into nextcloud:master Jan 16, 2020
@skjnldsv skjnldsv added this to the next milestone Jan 18, 2020
@skjnldsv skjnldsv modified the milestones: next, 3.1.7-3.1.9 Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Related to the design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants