Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting and wording of contact picture actions #1448

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Fix sorting and wording of contact picture actions #1448

merged 1 commit into from
Jan 28, 2020

Conversation

jancborchardt
Copy link
Member

  • Delete should always be last in list
  • Some minor wording fixes
  • Use proper Files icon

Before

contacts picture menu old

After

reordered menu

@jancborchardt
Fix sorting and wording of contact picture actions
37da95c 
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt jancborchardt added enhancement New feature or request 3. to review Waiting for reviews design Related to the design labels Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #1448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1448   +/-   ##
=======================================
  Coverage   62.31%   62.31%           
=======================================
  Files           4        4           
  Lines          69       69           
=======================================
  Hits           43       43           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a7d9d...37da95c. Read the comment docs.

@skjnldsv skjnldsv merged commit 0559d6e into master Jan 28, 2020
@skjnldsv skjnldsv deleted the design/viewer-actions branch January 28, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@hanzi hanzi Awaiting requested review from hanzi

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Related to the design enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jancborchardt @skjnldsv