Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix first contact sync #1488

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Fix first contact sync #1488

merged 1 commit into from
Feb 29, 2020

Conversation

skjnldsv
Copy link
Member

refs #1416 (comment)

Fix #1453

Feel free to test the release here: contacts.tar.gz

@skjnldsv
Fix first contact sync
894ec80 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews high High priority labels Feb 28, 2020
@skjnldsv skjnldsv added this to the 3.2.0 milestone Feb 28, 2020
@skjnldsv skjnldsv requested a review from hanzi February 28, 2020 16:34
@skjnldsv skjnldsv self-assigned this Feb 28, 2020
@skjnldsv skjnldsv mentioned this pull request Feb 28, 2020
Closed
@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #1488 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1488   +/-   ##
=========================================
  Coverage     75.43%   75.43%           
  Complexity       13       13           
=========================================
  Files             4        4           
  Lines            57       57           
=========================================
  Hits             43       43           
  Misses           14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32b0ab...894ec80. Read the comment docs.

@skjnldsv skjnldsv merged commit 28d71c8 into master Feb 29, 2020
@skjnldsv skjnldsv deleted the fix/first-contact-sync branch February 29, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanzi hanzi Awaiting requested review from hanzi

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Contact saving hangs and protocol says uid already exists
1 participant
@skjnldsv