Enh/add virtual group

[skjnldsv]

outdated gif

---

• Virtual group & Add group button
• Base UI
• Dav plugin
• Picker
  • Cleanup & fix UserBubble component
  • Standardisation
  • QA
• Progress
  • Modal
  • Animation
  • Finish state
  • QA
• Update local contacts
• QA

Bugs

• Do NOT provide read-only contacts
• Do NOT provide contacts that already belong to the group

[codecov]

Codecov Report

Merging #1687 into master will decrease coverage by 12.45%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master    #1687       +/-   ##
=============================================
- Coverage     40.05%   27.60%   -12.46%     
- Complexity      128      146       +18     
=============================================
  Files            17       18        +1     
  Lines           377      442       +65     
=============================================
- Hits            151      122       -29     
- Misses          226      320       +94     

Impacted Files	Coverage Δ	Complexity Δ
appinfo/app.php	0.00% <0.00%> (ø)	0.00 <0.00> (ø)
lib/AppInfo/Application.php	0.00% <0.00%> (ø)	3.00 <3.00> (+2.00)
lib/Controller/PageController.php	0.00% <0.00%> (-100.00%)	3.00 <0.00> (ø)
lib/Dav/PatchPlugin.php	0.00% <0.00%> (ø)	16.00 <16.00> (?)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ae90c...d3f8837. Read the comment docs.

[jancborchardt]

Some more review:

• The "New group" entry should be in var(--color-text-maxcontrast)
• When clicking the "New group" entry, the input field in the popdown could be focused so people can directly start typing
• Label of the "Add some" button in the group emptycontent would be better "Add contacts"
• After successful adding, the "Close" button is weirdly positioned right of the progress bar. Better would be below it, centered
  
• As said before: If there are no errors on adding, that modal can automatically be closed after ~3 seconds of showing the "Added …" feedback view.
• When there is only 1 or few contacts, the "Add some" modal vertically centers that contact (issue in the component I guess)
  
• You can add new groups, but there is no way to delete them
• Empty groups are removed on refresh. I guess this is to keep in line with spec? Just a bit confusing, but not so important
• If the counter is 0, the counter does not need to be shown. That’s a general thing true everywhere, and we can probably put that logic directly in the component?
• For some reason, I do get the "1 contact added to group" message, but the contact doesn’t seem to be actually added: the counter doesn’t go up, and the contact doesn’t show in the group? Getting this in the console:

Error: Request failed with status code 501
    createError createError.js:16
    settle settle.js:17
    handleLoad xhr.js:61
Contacts.vue:801
    _callee3$/</< Contacts.vue:801

[jancborchardt]

(Btw I’m also getting this error of "This contact was broken and received a fix …" on a completely new installations with a contact I just created with just a name. Anything I can do to fix that, or is there a pull request?)

[skjnldsv]

(Btw I’m also getting this error of "This contact was broken and received a fix …" on a completely new installations with a contact I just created with just a name. Anything I can do to fix that, or is there a pull request?)

Not related to this. No pr yet

[skjnldsv]

@jancborchardt let me merge and fix in followup so it's easier for me