Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import vcf from files #1688

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Import vcf from files #1688

merged 2 commits into from
Aug 21, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 7, 2020 •
edited
Loading

Capture d’écran_2020-07-24_11-01-17

@skjnldsv skjnldsv marked this pull request as ready for review July 7, 2020 13:55
@skjnldsv skjnldsv added 2. developing Work in progress enhancement New feature or request labels Jul 7, 2020
@skjnldsv skjnldsv force-pushed the enh/import-vcf-from-files branch 2 times, most recently from fa5390e to 2a43e52 Compare July 9, 2020 06:56
@codecov
Copy link

codecov bot commented Jul 9, 2020 •
edited
Loading

Codecov Report

Merging #1688 into master will decrease coverage by 0.36%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1688      +/-   ##
============================================
- Coverage     27.60%   27.23%   -0.37%     
- Complexity      146      148       +2     
============================================
  Files            18       19       +1     
  Lines           442      448       +6     
============================================
  Hits            122      122              
- Misses          320      326       +6
Impacted Files Coverage Δ Complexity Δ
lib/AppInfo/Application.php 0.00% <0.00%> (ø) 3.00 <0.00> (ø)
lib/Controller/PageController.php 0.00% <0.00%> (ø) 3.00 <0.00> (ø)
lib/Dav/PatchPlugin.php 0.00% <ø> (ø) 16.00 <0.00> (ø)
lib/Listener/LoadContactsFilesActions.php 0.00% <0.00%> (ø) 2.00 <2.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87615fb...f8a5d29. Read the comment docs.

@skjnldsv skjnldsv force-pushed the enh/add-virtual-group branch from dfd161e to b0c8d00 Compare July 14, 2020 07:14
@skjnldsv skjnldsv force-pushed the enh/import-vcf-from-files branch from e2700f1 to 53a8afc Compare July 14, 2020 07:26
@skjnldsv skjnldsv force-pushed the enh/add-virtual-group branch from b0c8d00 to eefe767 Compare July 14, 2020 07:33
@skjnldsv skjnldsv force-pushed the enh/import-vcf-from-files branch from 53a8afc to fa9c884 Compare July 14, 2020 07:33
@skjnldsv skjnldsv requested a review from jancborchardt July 24, 2020 09:01
@skjnldsv skjnldsv added this to the next minor milestone Jul 24, 2020
@jancborchardt

This comment has been minimized.

Sign in to view
This was referenced Aug 9, 2020
Closed
Closed
@skjnldsv skjnldsv force-pushed the enh/add-virtual-group branch 2 times, most recently from c179416 to d3f8837 Compare August 21, 2020 08:05
Base automatically changed from enh/add-virtual-group to master August 21, 2020 08:08
@skjnldsv
Import vcf from files
aaa23c1 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enh/import-vcf-from-files branch 4 times, most recently from c980e12 to 6c6f29f Compare August 21, 2020 08:21
@skjnldsv
Set import as default action & update webpack config
f8a5d29 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enh/import-vcf-from-files branch from 6c6f29f to f8a5d29 Compare August 21, 2020 08:34
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 21, 2020
@skjnldsv skjnldsv merged commit 8de4401 into master Aug 21, 2020
@skjnldsv skjnldsv deleted the enh/import-vcf-from-files branch August 21, 2020 10:20
@skjnldsv skjnldsv removed this from the next minor milestone Sep 6, 2020
@skjnldsv skjnldsv added this to the next milestone Sep 6, 2020
@skjnldsv skjnldsv modified the milestones: next, 3.4.0 Oct 1, 2020
@szaimen szaimen mentioned this pull request Nov 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@skjnldsv @jancborchardt