Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/virtual group #1770

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Fix/virtual group #1770

merged 2 commits into from
Sep 4, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 3, 2020 •
edited
Loading

Fix #1600
Fix #1753

@skjnldsv
Fix dialogs scss and notifications
791f215 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Fix virtual group
c7c23b9 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #1770 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1770   +/-   ##
=========================================
  Coverage     27.23%   27.23%           
  Complexity      148      148           
=========================================
  Files            19       19           
  Lines           448      448           
=========================================
  Hits            122      122           
  Misses          326      326
Impacted Files Coverage Δ Complexity Δ
lib/AppInfo/Application.php 0.00% <ø> (ø) 3.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03590a7...c7c23b9. Read the comment docs.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of bug Something isn't working labels Sep 3, 2020
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Sep 3, 2020
@skjnldsv skjnldsv merged commit 2ebd0d8 into master Sep 4, 2020
@skjnldsv skjnldsv deleted the fix/virtual-group branch September 4, 2020 06:42
@skjnldsv skjnldsv added this to the 3.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@jakobroehrl jakobroehrl Awaiting requested review from jakobroehrl

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
3.4.0
1 participant
@skjnldsv