Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default addressbook creation #1787

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Fix default addressbook creation #1787

merged 1 commit into from
Sep 7, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 6, 2020

Fix #1635

@skjnldsv
Fix default addressbook creation
63291b0 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Sep 6, 2020
@skjnldsv skjnldsv self-assigned this Sep 6, 2020
@skjnldsv skjnldsv requested a review from georgehrke September 6, 2020 10:13
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #1787 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1787   +/-   ##
=========================================
  Coverage     34.38%   34.38%           
  Complexity      148      148           
=========================================
  Files            19       19           
  Lines           442      442           
=========================================
  Hits            152      152           
  Misses          290      290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c00530f...63291b0. Read the comment docs.

@skjnldsv skjnldsv merged commit 041ec67 into master Sep 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/default-addressbook branch September 7, 2020 06:05
@skjnldsv skjnldsv added this to the 3.4.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@call-me-matt call-me-matt Awaiting requested review from call-me-matt

@georgehrke georgehrke Awaiting requested review from georgehrke

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

19.0.0RC2: no default address book created
2 participants
@skjnldsv @ChristophWurst