Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the app details toggle #1790

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Add back the app details toggle #1790

merged 1 commit into from
Sep 7, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 6, 2020

fix #1789

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Sep 6, 2020
@skjnldsv skjnldsv added this to the next milestone Sep 6, 2020
@skjnldsv skjnldsv self-assigned this Sep 6, 2020
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #1790 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1790   +/-   ##
=========================================
  Coverage     34.38%   34.38%           
  Complexity      148      148           
=========================================
  Files            19       19           
  Lines           442      442           
=========================================
  Hits            152      152           
  Misses          290      290           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6144342...c1ec4fc. Read the comment docs.

@call-me-matt
Copy link
Member

Navigation works fine, but it does not fix 1583 - you have to know its there!
grafik

Let's leave 1583 open for this: #1583 (comment)

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 7, 2020

Navigation works fine, but it does not fix 1583 - you have to know its there!
grafik

But it's not there... That's the point :)

Edit:, ah, I mistakenly understood the issue. In any case, #1583 is for the Vue components. There is already an issue for it on server as well. :)

@skjnldsv skjnldsv merged commit d52c997 into master Sep 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/app-details-toggle branch September 7, 2020 06:14
@skjnldsv skjnldsv modified the milestones: next, 3.4.0 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement mobile-navigation with contact details/list
2 participants