Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix placeholder display #1828

Merged
merged 1 commit into from
Oct 8, 2020
Merged

Fix placeholder display #1828

merged 1 commit into from
Oct 8, 2020

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 7, 2020

fix #1812

@skjnldsv
Fix placeholder display
dacd518 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature labels Oct 7, 2020
@skjnldsv skjnldsv added this to the next milestone Oct 7, 2020
@skjnldsv skjnldsv requested a review from call-me-matt October 7, 2020 06:46
@skjnldsv skjnldsv self-assigned this Oct 7, 2020
call-me-matt
call-me-matt approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@call-me-matt call-me-matt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't understand the code 100% - but I can confirm the issue is not present anymore with this.

@skjnldsv skjnldsv merged commit 67b6548 into master Oct 8, 2020
@skjnldsv skjnldsv deleted the fix/placeholder branch October 8, 2020 07:15
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 8, 2020

don't understand the code 100% - but I can confirm the issue is not present anymore with this.

We make sure localType is defined now, and if not we check if the property model have a placeholder entry :)

@skjnldsv skjnldsv removed this from the next milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@call-me-matt call-me-matt call-me-matt approved these changes

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

email address not shown in minimal contact in Contacts 3.4.0
2 participants
@skjnldsv @call-me-matt