Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore errors from invalid social ids #1829

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

call-me-matt
Copy link
Member

ignore errors so background syncs can continue when updating the social avatars in a complete address book

Signed-off-by: call-me-matt nextcloud@matthiasheinisch.de

Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
@call-me-matt call-me-matt requested a review from skjnldsv October 7, 2020 12:57
@call-me-matt call-me-matt self-assigned this Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@604e1b1). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1829   +/-   ##
=========================================
  Coverage          ?   36.87%           
  Complexity        ?      162           
=========================================
  Files             ?       19           
  Lines             ?      499           
  Branches          ?        0           
=========================================
  Hits              ?      184           
  Misses            ?      315           
  Partials          ?        0           
Impacted Files Coverage Δ Complexity Δ
lib/Service/SocialApiService.php 87.21% <0.00%> (ø) 47.00 <0.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 604e1b1...67a1cdd. Read the comment docs.

@skjnldsv skjnldsv merged commit eb24345 into nextcloud:master Oct 7, 2020
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working labels Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants