Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding diaspora to the list for social sync #1853

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Conversation

call-me-matt
Copy link
Member

Signed-off-by: call-me-matt nextcloud@matthiasheinisch.de

@call-me-matt call-me-matt added enhancement New feature or request 3. to review Waiting for reviews labels Oct 15, 2020
@call-me-matt call-me-matt requested a review from skjnldsv October 15, 2020 09:34
@call-me-matt call-me-matt self-assigned this Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020

Codecov Report

Merging #1853 into master will decrease coverage by 1.90%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1853      +/-   ##
============================================
- Coverage     37.02%   35.11%   -1.91%     
- Complexity      160      170      +10     
============================================
  Files            19       20       +1     
  Lines           497      524      +27     
============================================
  Hits            184      184              
- Misses          313      340      +27     
Impacted Files Coverage Δ Complexity Δ
lib/Service/Social/CompositeSocialProvider.php 0.00% <0.00%> (ø) 10.00 <0.00> (ø)
lib/Service/Social/DiasporaProvider.php 0.00% <0.00%> (ø) 10.00 <10.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dcbafc...5e6f65a. Read the comment docs.

Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, code looks good! 🐘

@skjnldsv skjnldsv merged commit 86a5597 into master Oct 15, 2020
@skjnldsv skjnldsv deleted the enh/social-diaspora branch October 15, 2020 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants