Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add xing to social sync #1869

Merged
merged 1 commit into from
Oct 21, 2020
Merged

add xing to social sync #1869

merged 1 commit into from
Oct 21, 2020

Conversation

call-me-matt
Copy link
Member

@call-me-matt call-me-matt commented Oct 20, 2020

fixes #1868

Probably not very reliable, let's see how long it lasts.

Signed-off-by: call-me-matt nextcloud@matthiasheinisch.de

Signed-off-by: call-me-matt <nextcloud@matthiasheinisch.de>
@call-me-matt call-me-matt requested a review from skjnldsv October 20, 2020 21:17
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #1869 into master will decrease coverage by 1.41%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1869      +/-   ##
============================================
- Coverage     35.11%   33.69%   -1.42%     
- Complexity      170      178       +8     
============================================
  Files            20       21       +1     
  Lines           524      546      +22     
============================================
  Hits            184      184              
- Misses          340      362      +22     
Impacted Files Coverage Δ Complexity Δ
lib/Service/Social/CompositeSocialProvider.php 0.00% <0.00%> (ø) 10.00 <0.00> (ø)
lib/Service/Social/XingProvider.php 0.00% <0.00%> (ø) 8.00 <8.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64c4d3f...6b127fc. Read the comment docs.

@call-me-matt call-me-matt self-assigned this Oct 20, 2020
@call-me-matt call-me-matt added 3. to review Waiting for reviews enhancement New feature or request labels Oct 20, 2020
@skjnldsv
Copy link
Member

Code looks good. Didn't test :)

@call-me-matt call-me-matt merged commit f660cef into master Oct 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the enh/social-xing branch October 21, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download contact pictures from Xing
2 participants