Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bulk contacts add to group #1883

Merged
merged 1 commit into from
Nov 7, 2020
Merged

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 26, 2020

Fix #1874

Before:

  1. Try to add contacts to a group
  2. Press Add
  3. See it fails, and you cannot close the modal

After:

  1. Test this pr.
  2. Contacts works and progress Modal is displayed

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Oct 26, 2020
@skjnldsv skjnldsv added this to the next milestone Oct 26, 2020
@skjnldsv skjnldsv requested a review from call-me-matt October 26, 2020 09:51
@skjnldsv skjnldsv self-assigned this Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #1883 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1883   +/-   ##
=========================================
  Coverage     33.69%   33.69%           
  Complexity      178      178           
=========================================
  Files            21       21           
  Lines           546      546           
=========================================
  Hits            184      184           
  Misses          362      362           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55812a4...8d5a93c. Read the comment docs.

@skjnldsv skjnldsv merged commit 23e887b into master Nov 7, 2020
@skjnldsv skjnldsv deleted the fix/bulk/contacts-group-add branch November 7, 2020 16:22
@skjnldsv skjnldsv removed this from the next milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot bulk add contacts to groups
1 participant