Fix custom labels not being displayed

[j-maas]

Should fix #1842.

The canDisplay filtering was introduced almost a year ago. It checks whether the property name is "registered" in rfcProps.js, and if not, it does not pass it along.

The problem is that custom labels are implemented by using two vCard fields with the same, e.g., group1.X-ABLabel and group1.TEL, where the . separates the prefix from the field types. The sorting function sorts by what is after the ., since we are not interested in the prefix. By the same logic, we should only check what is after the . for whether it is a property we can display.

I don't have the energy to figure out how to test this change. But I'm confident enough that this is the fix that I wanted to propose it in the form of a PR.

[j-maas]

Sorry, I had an embarrassing missing paren, so I edited the commit.

[j-maas]

And now DCO is happy.

[j-maas]

And now I turned of my auto-formatter. Sorry for the noise.

[skjnldsv]

Hey, thanks for this!
The fix should go in the canDisplay method.

contacts/src/components/ContactDetails.vue

Lines 763 to 770 in 5c63289

	const propType = propModel && propModel.force
	? propModel.force
	: property.getDefaultType()
	return propModel && propType !== 'unknown'
	},
	/**

Here you drop the normal properties. You need to stay compatible with the non-split properties

[skjnldsv]

Done, I pushed! @y0hy0h please double check my changes :)

Thanks a lot for narrowing this!

[j-maas]

Yeah, this makes sense! Also great idea to add the comment.

I'm happy it helped! Thanks for fixing the fix so quickly. 😊

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

[sciurius]

I can confirm that this solved the problem for me. I have many contacts that have ADR entries similar to

item0.ADR;TYPE=HOME: ...
item0.X-ABADRLnl

With the fix the address information is displayed again.

Thanks, Johannes!

[skjnldsv]

I'll release a new version as soon as possible

[PHP-Expert]

#3645