Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show loading icon when deleting or renaming groups #4013

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jul 8, 2024

Follow-up to #3957 (comment)

Note: The recordings are done with a throttled connection to emphasize the impact.

Bildschirmaufnahme_20240708_103524.mp4
Bildschirmaufnahme_20240708_103431.mp4

@st3iny st3iny added enhancement New feature or request 3. to review Waiting for reviews labels Jul 8, 2024
@st3iny st3iny added this to the v6.1.0 milestone Jul 8, 2024
@st3iny st3iny self-assigned this Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.90%. Comparing base (d8b9150) to head (0f43086).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4013   +/-   ##
=========================================
  Coverage     65.90%   65.90%           
  Complexity      261      261           
=========================================
  Files            24       24           
  Lines           786      786           
=========================================
  Hits            518      518           
  Misses          268      268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@GVodyanov GVodyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/group-loading-state branch from d4a9974 to 0f43086 Compare July 15, 2024 10:20
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 15, 2024
@st3iny st3iny merged commit 55f94ef into main Jul 15, 2024
26 checks passed
@st3iny st3iny deleted the fix/group-loading-state branch July 15, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

2 participants