Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search, structure and design fixes for 14 #588

Merged
merged 1 commit into from
Aug 2, 2018
Merged

Search, structure and design fixes for 14 #588

merged 1 commit into from
Aug 2, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 1, 2018

Fixes #586

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

Test release: contacts.tar.gz

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Aug 1, 2018
@skjnldsv skjnldsv added 3. to review Waiting for reviews design Related to the design compatibility Compatibility with other services high High priority labels Aug 1, 2018
@skjnldsv skjnldsv requested a review from rullzer August 1, 2018 12:39
@codecov
Copy link

codecov bot commented Aug 1, 2018

Codecov Report

Merging #588 into master will increase coverage by 0.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #588      +/-   ##
==========================================
+ Coverage   15.87%   15.88%   +0.01%     
==========================================
  Files          62       62              
  Lines        1405     1404       -1     
==========================================
  Hits          223      223              
+ Misses       1182     1181       -1
Impacted Files Coverage Δ
...onents/contactDetails/contactDetails_controller.js 1.56% <0%> (-0.06%) ⬇️
js/services/search_service.js 4% <16.66%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f87c27a...5002c1c. Read the comment docs.

@sleepypioneer
Copy link
Member

Noted 🗒

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works again over here!

@skjnldsv skjnldsv merged commit 7bc1f53 into master Aug 2, 2018
@skjnldsv skjnldsv deleted the 14-fixes branch August 2, 2018 09:18
@skjnldsv skjnldsv restored the 14-fixes branch August 2, 2018 09:18
@skjnldsv skjnldsv deleted the 14-fixes branch August 2, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews compatibility Compatibility with other services design Related to the design high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants