Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced PHP fixer #1011

Merged
merged 6 commits into from
Jun 22, 2022
Merged

Enhanced PHP fixer #1011

merged 6 commits into from
Jun 22, 2022

Conversation

christianlupus
Copy link
Collaborator

Closes #1008
Closes #619

This should be easy to rebase. Thus, it should be merged if no big upcoming PRs regarding the backend are WIP.

@codecov
Copy link

codecov bot commented May 21, 2022

Codecov Report

Merging #1011 (848988a) into master (fe66d88) will decrease coverage by 15.07%.
The diff coverage is 50.00%.

❗ Current head 848988a differs from pull request most recent head d14ba50. Consider uploading reports for the commit d14ba50 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1011       +/-   ##
===========================================
- Coverage   42.13%   27.05%   -15.08%     
===========================================
  Files          44       32       -12     
  Lines        1875     1619      -256     
===========================================
- Hits          790      438      -352     
- Misses       1085     1181       +96     
Flag Coverage Δ
migration ?
unittests 27.05% <50.00%> (-10.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/AppInfo/Application.php 0.00% <ø> (ø)
lib/Controller/ConfigController.php 100.00% <ø> (ø)
lib/Controller/MainController.php 100.00% <ø> (ø)
lib/Controller/RecipeController.php 100.00% <ø> (ø)
lib/Db/DbTypesPolyfillHelper.php 0.00% <ø> (ø)
lib/Db/RecipeDb.php 0.00% <ø> (ø)
lib/Helper/AcceptHeaderParsingHelper.php 100.00% <ø> (ø)
lib/Helper/ImageService/ImageFileHelper.php 100.00% <ø> (ø)
lib/Helper/ImageService/ImageGenerationHelper.php 100.00% <ø> (ø)
lib/Helper/ImageService/ThumbnailFileHelper.php 97.05% <ø> (ø)
... and 35 more

@github-actions
Copy link

github-actions bot commented May 21, 2022

Unit Test Results

     24 files       24 suites   8m 39s ⏱️
   200 tests    200 ✔️ 0 💤 0
2 400 runs  2 400 ✔️ 0 💤 0

Results for commit d14ba50.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
See #619

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus force-pushed the fix/1008-php-cs-fixer branch from 036bacc to d14ba50 Compare June 19, 2022 07:37
@christianlupus christianlupus marked this pull request as ready for review June 22, 2022 15:55
@christianlupus christianlupus merged commit 7a72fec into master Jun 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/1008-php-cs-fixer branch June 22, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add configuration for PHP linter Check if Guzzle is needed
1 participant