Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable downloading using curl #1055

Merged
merged 5 commits into from
Jun 23, 2022
Merged

Conversation

christianlupus
Copy link
Collaborator

Closes #979

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
…e in PRs

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1055 (58ff14f) into master (4e5d528) will decrease coverage by 1.01%.
The diff coverage is 17.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
- Coverage   42.11%   41.09%   -1.02%     
==========================================
  Files          44       46       +2     
  Lines        1876     1925      +49     
==========================================
+ Hits          790      791       +1     
- Misses       1086     1134      +48     
Flag Coverage Δ
migration 4.41% <0.00%> (-0.12%) ⬇️
unittests 36.67% <17.85%> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Db/RecipeDb.php 0.00% <0.00%> (ø)
lib/Exception/NoDownloadWasCarriedOutException.php 0.00% <0.00%> (ø)
lib/Helper/DownloadHelper.php 0.00% <0.00%> (ø)
lib/Service/HtmlDownloadService.php 100.00% <100.00%> (ø)
lib/Exception/ImportException.php 0.00% <0.00%> (-100.00%) ⬇️

@github-actions
Copy link

Unit Test Results

     24 files       24 suites   8m 38s ⏱️
   202 tests    202 ✔️ 0 💤 0
2 424 runs  2 424 ✔️ 0 💤 0

Results for commit ca7f322.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus merged commit 1ca8900 into master Jun 23, 2022
@christianlupus christianlupus deleted the fix/979-curl-downloader branch June 23, 2022 19:29
christianlupus added a commit that referenced this pull request Jun 24, 2022
Fix for #1055

Signed-off-by: Christian Wolf <github@christianwolf.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using cURL instead of file_get_contents for recipe import
1 participant