Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyword ordering buttons clipped by top bar #1103

Merged

Conversation

MarcelRobitaille
Copy link
Collaborator

Fixes #1100

If there are no keywords, I just don't show the ordering buttons. I also updated the styles using flexbox to layout the buttons a bit better (IMO). Before, the buttons were slightly under the keywords. Now, they are top-aligned.

Before:

image

After:
image

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
@github-actions
Copy link

Unit Test Results

     36 files       36 suites   10m 8s ⏱️
   402 tests    402 ✔️ 0 💤 0
4 824 runs  4 824 ✔️ 0 💤 0

Results for commit bd7f506.

Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christianlupus christianlupus merged commit f8a45e1 into nextcloud:master Jul 24, 2022
@MarcelRobitaille MarcelRobitaille deleted the 1100-fix-sort-buttons-clipped branch July 24, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting toggles under titlebar if no keywords assigned
2 participants