Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling of recipe view #1112

Merged
merged 4 commits into from
Jul 26, 2022
Merged

Fix styling of recipe view #1112

merged 4 commits into from
Jul 26, 2022

Conversation

christianlupus
Copy link
Collaborator

Fixes a small bug in #1107.

When the instructions are longer than the side column,
the side column should not be stretched vertically.

Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #1112 (07000ef) into master (dde36fd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1112   +/-   ##
=======================================
  Coverage   57.89%   57.89%           
=======================================
  Files          73       73           
  Lines        2292     2292           
=======================================
  Hits         1327     1327           
  Misses        965      965           
Flag Coverage Δ
integration 1.96% <0.00%> (ø)
migration 4.05% <0.00%> (ø)
unittests 51.87% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Helper/Filter/JSON/FixRecipeYieldFilter.php 100.00% <100.00%> (ø)

@github-actions
Copy link

github-actions bot commented Jul 25, 2022

Unit Test Results

     36 files       36 suites   10m 52s ⏱️
   403 tests    403 ✔️ 0 💤 0
4 836 runs  4 836 ✔️ 0 💤 0

Results for commit 6f1eafa.

♻️ This comment has been updated with latest results.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

Closes #1111

@christianlupus christianlupus linked an issue Jul 26, 2022 that may be closed by this pull request
@christianlupus christianlupus merged commit a4ab17c into master Jul 26, 2022
@christianlupus christianlupus deleted the fix/grid-column-length branch July 26, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

l10n: Understanding issue with "recipeYield"
1 participant