Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the controllers to close CSRF attack vectors #1190

Merged
merged 7 commits into from
Sep 2, 2022

Conversation

christianlupus
Copy link
Collaborator

Closes #1179

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #1190 (f05d678) into master (4bc72cb) will increase coverage by 1.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
+ Coverage   58.02%   59.53%   +1.50%     
==========================================
  Files          75       86      +11     
  Lines        2311     2387      +76     
==========================================
+ Hits         1341     1421      +80     
+ Misses        970      966       -4     
Flag Coverage Δ
integration 5.57% <0.00%> (-0.19%) ⬇️
migration 3.89% <0.00%> (-0.13%) ⬇️
unittests 54.02% <100.00%> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Controller/MainController.php 100.00% <ø> (ø)
lib/Controller/CategoryApiController.php 100.00% <100.00%> (ø)
lib/Controller/CategoryController.php 100.00% <100.00%> (ø)
lib/Controller/ConfigApiController.php 100.00% <100.00%> (ø)
lib/Controller/ConfigController.php 100.00% <100.00%> (ø)
...ntroller/Implementation/CategoryImplementation.php 100.00% <100.00%> (ø)
...Controller/Implementation/ConfigImplementation.php 100.00% <100.00%> (ø)
...ontroller/Implementation/KeywordImplementation.php 100.00% <100.00%> (ø)
...Controller/Implementation/RecipeImplementation.php 100.00% <100.00%> (ø)
lib/Controller/KeywordApiController.php 100.00% <100.00%> (ø)
... and 6 more

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Unit Test Results

     33 files       33 suites   7m 40s ⏱️
   458 tests    458 ✔️ 0 💤 0
5 038 runs  5 038 ✔️ 0 💤 0

Results for commit f05d678.

@christianlupus christianlupus merged commit 660c0a7 into master Sep 2, 2022
@christianlupus christianlupus deleted the fix/1179-rename-controllers branch September 2, 2022 14:03
lneugebauer added a commit to lneugebauer/nextcloud-cookbook that referenced this pull request Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent CSRF attacks
1 participant