Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parts of #1603 #1743

Closed
wants to merge 0 commits into from
Closed

Fix missing parts of #1603 #1743

wants to merge 0 commits into from

Conversation

j0hannesr0th
Copy link
Contributor

Topic and Scope

Fix the problems described here: #1603 (comment)

See it here:

Screencast.from.30.06.2023.23.38.52.webm

Concerns/issues

@christianlupus what do you think about fraction handling like this?

I did some research and found this: https://github.com/infusion/Fraction.js/

I'm not sure if you want some 3rd party lib just for fraction handling.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@github-actions
Copy link

github-actions bot commented Jun 30, 2023

Test Results

     27 files  1 233 suites   7m 59s ⏱️
   498 tests    498 ✔️ 0 💤 0
4 482 runs  4 481 ✔️ 1 💤 0

Results for commit 35dfb31.

♻️ This comment has been updated with latest results.

@christianlupus
Copy link
Collaborator

This was superseded by #1765

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants