chore: upgrade docs to docker compose v2 #1772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Scope
Upgrades instructions and the local test runner to use Docker Compose v2 instead of Docker Compose.
Docker Compose v2 has been out for some time, and Docker Compose v1 (
docker-compose
) no longer receives updates.I think it makes sense to push the documentation and commands over to the v2 equivalents now, since this is what most engineers should have installed now.
Concerns/issues
I have only tested this locally. I'm not sure if this will work as-is on CI or if more needs to be done.
It's also worth considering if a significant portion of maintainers/contributors cannot upgrade to Docker Compose v2 for some reason? 🤔 (I can't think of one, but I'm just wary as I don't know why this repository was still using
docker-compose
instead ofdocker compose
.)A similar proposal was made for nextcloud-docker-dev, which looks like it will be merged soon too:
Formal requirements
There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.