Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove client 'nook' from docs #2225

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix: remove client 'nook' from docs #2225

merged 2 commits into from
May 1, 2024

Conversation

shagn
Copy link
Contributor

@shagn shagn commented Mar 31, 2024

Topic and Scope

The PR removes the client 'nook' from the clients page since it is not longer available. The link to the Play Store does not work and also with a search I could not find it.

Concerns/issues

Is the PR potentially cause any issues that might be of interest? Any other issues to be tought of?

No

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus
Copy link
Collaborator

I will have to check this out.

A quick research found https://apkpure.net/de/nook-nextcloud-cookbook/org.capacitor.cookbook.app and https://apkpure.com/de/nook-nextcloud-cookbook/org.capacitor.cookbook.app/download.

Lets see if we can reach the developer.

shagn and others added 2 commits May 1, 2024 10:46
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporarily accepted until a clear statement from the developer comes to me. Until then we drop the Nook links

@christianlupus christianlupus enabled auto-merge May 1, 2024 08:49
@christianlupus christianlupus merged commit 349720b into nextcloud:master May 1, 2024
18 checks passed
@Leptopoda Leptopoda mentioned this pull request May 2, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants