Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default server time zone if non provided #2333

Merged
merged 2 commits into from
May 30, 2024

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented May 26, 2024

Topic and Scope

Closes #1456

Concerns/issues

This is mainly a quick fix as the timezone information is not present in the database ATM. Instead, the server time zone is used and assumed stable.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus christianlupus marked this pull request as ready for review May 26, 2024 18:04
Copy link

github-actions bot commented May 26, 2024

Test Results

   12 files    584 suites   1m 33s ⏱️
  573 tests   573 ✅ 0 💤 0 ❌
2 292 runs  2 291 ✅ 1 💤 0 ❌

Results for commit 6ac73b4.

♻️ This comment has been updated with latest results.

@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus force-pushed the fix/1456-timezone-in-recipe-stub branch from 75d0844 to 2303885 Compare May 29, 2024 19:37
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus force-pushed the fix/1456-timezone-in-recipe-stub branch from 2303885 to 6ac73b4 Compare May 30, 2024 08:20
@christianlupus christianlupus merged commit 49a49e5 into master May 30, 2024
31 checks passed
@christianlupus christianlupus deleted the fix/1456-timezone-in-recipe-stub branch May 30, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recipe Created Time on Main Screen
2 participants