Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use underscores to prevent trailing dot in folder names #2343

Merged
merged 2 commits into from
May 30, 2024

Conversation

christianlupus
Copy link
Collaborator

@christianlupus christianlupus commented May 30, 2024

Topic and Scope

Closes #2332

Concerns/issues

There could be name clashes if the first 97 chars of two recipes are equal.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Copy link

Test Results

   12 files    584 suites   1m 33s ⏱️
  573 tests   573 ✅ 0 💤 0 ❌
2 292 runs  2 291 ✅ 1 💤 0 ❌

Results for commit 533005f.

@christianlupus
Copy link
Collaborator Author

In case there are already some recipes with the trailing dot, the user has to open the recipe and just store it again. That will move it to the correct location without a trailing dot.

@christianlupus christianlupus marked this pull request as ready for review May 30, 2024 11:43
@christianlupus
Copy link
Collaborator Author

/approve

Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@christianlupus christianlupus merged commit 08b12d6 into master May 30, 2024
34 checks passed
@christianlupus christianlupus deleted the fix/2332-abbreviated-folder-names-sync branch May 30, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long folder names create sync error
2 participants