Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the app compatible to NC server 30 #2493

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Make the app compatible to NC server 30 #2493

merged 6 commits into from
Sep 12, 2024

Conversation

christianlupus
Copy link
Collaborator

Topic and Scope

This is a preparation to make the upcoming release to let it run with the new server version.

Concerns/issues

The new server version was not tested much on NC30. Regressions might happen.

Formal requirements

There are some formal requirements that should be satisfied. Please mark those by checking the corresponding box.

  • I did check that the app can still be opened and does not throw any browser logs
  • I created tests for newly added PHP code (check this if no PHP changes were made)
  • I updated the OpenAPI specs and added an entry to the API changelog (check if API was not modified)
  • I notified the matrix channel if I introduced an API change

@christianlupus
Formally make the app compatible with NC 30
a62896f 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Fix a warning of vue compiler about SCSS ordering
c910fa0 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Fix hook to download XSD file first
7bc47fc 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Update Changelog
87da00f 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Fix gitignore file
ffb4635 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus marked this pull request as ready for review September 12, 2024 10:08
@christianlupus
Extend GH test configuration
d04e412 
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus
Copy link
Collaborator Author

/approve

nextcloud-cookbook-bot
nextcloud-cookbook-bot approved these changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@nextcloud-cookbook-bot nextcloud-cookbook-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by GitHub action on behalf of /approve

@github-actions GitHub Actions
Copy link

Test Results

   12 files    584 suites   1m 36s ⏱️
  575 tests   575 ✅ 0 💤 0 ❌
2 300 runs  2 299 ✅ 1 💤 0 ❌

Results for commit d04e412.

@christianlupus christianlupus merged commit ec4f508 into master Sep 12, 2024
30 checks passed
@christianlupus christianlupus deleted the main/compatibility-nc30 branch September 12, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextcloud-cookbook-bot nextcloud-cookbook-bot nextcloud-cookbook-bot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christianlupus @nextcloud-cookbook-bot