Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for recipeInstructions #347

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

victorjoos
Copy link
Contributor

@victorjoos victorjoos commented Oct 20, 2020

Some json recipes (like on https://www.colruyt.be/fr/en-cuisine/meli-melo-de-legumes-oublies-au-chevre) don't contain the array directly, but have it inside the 'itemListElement'. While this is clearly a mistaken understanding of the spec, this is a workaround that shouldn't impact existing json parsing.

Thank you very much for the project and the work !

Some json recipes don't contain the array directly, but have it inside the 'itemListElement'. While this is clearly a mistaken understanding of the spec, this is a workaround that shouldn't impact existing json parsing.

Signed-off-by: Victor Joos <victorjoosdtb@gmail.com>
@christianlupus
Copy link
Collaborator

In general this looks good to me. However, there are multiple things to consider/extend here:

  1. The page should be made aware to stick with the schema.org standard.
  2. The parsing is not ideal at this location. The standard allows to parse the instructions as a ItemList of HowToSteps. We are not capable to parse that at the moment.

During the rework towards point 2 this issue might come up again. Thus, I am merging here in a quick way.

@christianlupus christianlupus merged commit 0a2b135 into nextcloud:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants