Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code checker tests in CI and build correct deployment files in CI #435

Merged

Conversation

christianlupus
Copy link
Collaborator

This PR implements two functions

  • Run the NC code checker on the app code to ensure the code requirements are met.
  • Build a valid installation tarball during CI runs

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>

Remove webpack config from tarball

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #435 (8d0946a) into master (a3713d1) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #435   +/-   ##
========================================
  Coverage      0.95%   0.95%           
  Complexity      401     401           
========================================
  Files            13      13           
  Lines          1263    1263           
========================================
  Hits             12      12           
  Misses         1251    1251           
Flag Coverage Δ Complexity Δ
integration 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
unittests 0.95% <20.00%> (ø) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Db/RecipeDb.php 0.00% <0.00%> (ø) 56.00 <0.00> (ø)
lib/Service/DbCacheService.php 0.00% <0.00%> (ø) 44.00 <0.00> (ø)
lib/Service/RecipeService.php 0.00% <0.00%> (ø) 224.00 <0.00> (ø)
lib/Service/JsonService.php 100.00% <100.00%> (ø) 7.00 <0.00> (ø)

@christianlupus christianlupus merged commit 13cbbeb into nextcloud:master Dec 12, 2020
@christianlupus christianlupus deleted the dev/enhence-ci branch December 12, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant