Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pasting of normal content #503

Merged
merged 2 commits into from
Jan 13, 2021
Merged

Conversation

christianlupus
Copy link
Collaborator

Closes #475

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #503 (51eea94) into master (d443fe4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #503   +/-   ##
========================================
  Coverage      0.90%   0.90%           
  Complexity      416     416           
========================================
  Files            13      13           
  Lines          1319    1319           
========================================
  Hits             12      12           
  Misses         1307    1307           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 0.90% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus
Copy link
Collaborator Author

@seyfeb would you please share your thoughts on this? I tried to keep things simple.

@christianlupus christianlupus force-pushed the fix/475-pasting-single-lines branch from 8dde000 to c512063 Compare January 12, 2021 09:06
@seyfeb
Copy link
Collaborator

seyfeb commented Jan 12, 2021

I also addressed this while I was editing the file in #497.
My solution was intended to give more flexibility if, in the future, we would like to modify the behavior when pasting. But maybe it’s even better to have a simple solution as you proposed here.
Anyway, this looks fine and works well for me.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus force-pushed the fix/475-pasting-single-lines branch from c512063 to 51eea94 Compare January 13, 2021 09:46
@christianlupus christianlupus merged commit 58a0b97 into master Jan 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/475-pasting-single-lines branch January 13, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single pasted tool/instruction/ingredient is not saved
2 participants