Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile with maintainer #582

Merged
merged 2 commits into from
Feb 14, 2021

Conversation

christianlupus
Copy link
Collaborator

Add a maintainer according to docker image guidelines

@christianlupus christianlupus self-assigned this Feb 14, 2021
@codecov
Copy link

codecov bot commented Feb 14, 2021

Codecov Report

Merging #582 (94273a1) into master (29bac9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #582   +/-   ##
========================================
  Coverage      1.01%   1.01%           
  Complexity      440     440           
========================================
  Files            13      13           
  Lines          1374    1374           
========================================
  Hits             14      14           
  Misses         1360    1360           
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 1.01% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@christianlupus christianlupus force-pushed the dev/update-dockerfile-with-maintainer branch from 7683cc3 to 817d93d Compare February 14, 2021 10:48
@christianlupus christianlupus marked this pull request as ready for review February 14, 2021 11:47
@@ -2,6 +2,8 @@
ARG PHPVERSION
FROM php:${PHPVERSION}-fpm

LABEL maintainer="Christian Wolf <github@christianwolf.github>"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, you mistyped your email address here? :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yupp....

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus force-pushed the dev/update-dockerfile-with-maintainer branch from b87aacc to 94273a1 Compare February 14, 2021 12:10
@christianlupus christianlupus merged commit a325d89 into master Feb 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the dev/update-dockerfile-with-maintainer branch February 14, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants