-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show error message upon import exception #647
Conversation
Codecov Report
@@ Coverage Diff @@
## master #647 +/- ##
========================================
Coverage 0.99% 0.99%
Complexity 452 452
========================================
Files 15 15
Lines 1414 1414
========================================
Hits 14 14
Misses 1400 1400
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@seyfeb as the original line in the |
I think there is always some response from the server?* To be sure one could provide a default feedback to the user if it’s empty.
|
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
ce741bd
to
be3e340
Compare
Coded along https://github.com/axios/axios#handling-errors Signed-off-by: Christian Wolf <github@christianwolf.email>
@seyfeb I had a look at the axios documentation once more and came up with a bit more secure code in the sense that exceptions are handled more explicitly. |
I think this should be fine, except for the failing linters 😄 |
Signed-off-by: Christian Wolf <github@christianwolf.email>
The linters are taken care of. |
This solves partially the issue described in #626 as it avoids an empty alert box.