Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated styling of code according to cs fixer #668

Merged
merged 2 commits into from
Mar 27, 2021
Merged

Conversation

christianlupus
Copy link
Collaborator

This should cover the issues regarding the new code styling issues

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #668 (acf6fa1) into master (3e24554) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head acf6fa1 differs from pull request most recent head 1c50e09. Consider uploading reports for the commit 1c50e09 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##             master    #668   +/-   ##
========================================
  Coverage      0.99%   0.99%           
  Complexity      452     452           
========================================
  Files            15      15           
  Lines          1414    1413    -1     
========================================
  Hits             14      14           
+ Misses         1400    1399    -1     
Flag Coverage Δ Complexity Δ
integration 0.00% <ø> (ø) 0.00 <ø> (ø)
unittests 0.99% <ø> (+<0.01%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/Controller/ConfigController.php 0.00% <ø> (ø) 7.00 <0.00> (ø)
lib/Controller/MainController.php 0.00% <ø> (ø) 40.00 <0.00> (ø)
lib/Controller/RecipeController.php 0.00% <ø> (ø) 14.00 <0.00> (ø)
lib/Db/DbTypesPolyfillHelper.php 0.00% <ø> (ø) 6.00 <0.00> (ø)
lib/Db/RecipeDb.php 0.00% <ø> (ø) 57.00 <0.00> (ø)
lib/Exception/InvalidJSONFileException.php 0.00% <ø> (ø) 1.00 <0.00> (ø)
lib/Exception/UserFolderNotWritableException.php 0.00% <ø> (ø) 1.00 <0.00> (ø)
lib/Helper/RestParameterParser.php 0.00% <ø> (ø) 20.00 <0.00> (ø)
lib/Migration/Version000000Date20190312140601.php 0.00% <ø> (ø) 3.00 <0.00> (ø)
lib/Migration/Version000000Date20190910100911.php 0.00% <ø> (ø) 3.00 <0.00> (ø)
... and 6 more

@christianlupus christianlupus merged commit 22bd511 into master Mar 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the new-code-styles branch March 27, 2021 18:03
@PFischbeck
Copy link
Contributor

Just as heads-up: the next version of PHP CS Fixer will apparently reverse the enforced behavior again, since this was an implementation error on their end. See this issue and this PR.

@christianlupus
Copy link
Collaborator Author

Just as heads-up: the next version of PHP CS Fixer will apparently reverse the enforced behavior again, since this was an implementation error on their end. See this issue and this PR.

Thanks for the hint. We will have to deal with it then. But it should not be too critical. Everything was automatically fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants