Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated/added screenshots for the Nextcloud App Store #747

Merged
merged 4 commits into from
Jun 29, 2021

Conversation

mMuck
Copy link
Contributor

@mMuck mMuck commented Jun 18, 2021

1920p width, 2 different ones.
Bug fixed: The appinfo/info.xml referred only to the thumbnail as the full size screenshot.
Resolves #635 - this is my first pull request. Surly I did something wrong with my request...

@seyfeb
Copy link
Collaborator

seyfeb commented Jun 21, 2021

@mMuck when you click on 'Details' of the failed workflow (in your case DCO), it shows you instructions on how to fix this PR! :)

Screenshot 2021-06-21 at 10 54 25

Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the template in .github/actions/deploy/info.xml.dist as well as indicated in line 2. Otherwise, the changes to the info.xml will be lost upon next release cycle.

A side remark: The parser on the app store requests the XML file elements to be in a defined order. If the order is wrong, the elements are ignored. Please check this (I did not do it).

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #747 (7eb2161) into master (90e7d28) will not change coverage.
The diff coverage is n/a.

❗ Current head 7eb2161 differs from pull request most recent head 247f35a. Consider uploading reports for the commit 247f35a to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##             master    #747   +/-   ##
========================================
  Coverage      0.94%   0.94%           
  Complexity      463     463           
========================================
  Files            19      19           
  Lines          1476    1476           
========================================
  Hits             14      14           
  Misses         1462    1462           
Flag Coverage Δ
integration 0.00% <ø> (ø)
unittests 0.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

mMuck and others added 4 commits June 29, 2021 19:02
1920p width

Signed-off-by: mMuck <git@muckies.com>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>

# Conflicts:
#	CHANGELOG.md
@christianlupus christianlupus merged commit b5a43c3 into nextcloud:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update image in NC app store
3 participants