Use var(--header-height) not hard-coded 50px for breadcrums sticky position #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me> Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
christianlupus
force-pushed
the
fix-hard-50px-header
branch
from
d55dd88 to
4348bb9
Compare
Codecov Report
@@ Coverage Diff @@
## master #897 +/- ##
=======================================
Coverage 21.22% 21.22%
=======================================
Files 20 20
Lines 1555 1555
=======================================
Hits 330 330
Misses 1225 1225
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #888 where the appcontrol breadcrums were given a position based on the hard-coded value
50px. Instead, use the variable--header-heightso that this code is adapted if the header height changes..