Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim multiple whitespace characters when pasting #924

Merged

Conversation

MarcelRobitaille
Copy link
Collaborator

Fixes #713

Now, when multiple whitespace characters appear when pasting recipe ingredients, instructions, etc. they are replace by a single space.

image

@MarcelRobitaille MarcelRobitaille changed the title 713 trim multiple whitespaces Trim multiple whitespace characters when pasting Mar 20, 2022
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #924 (0eae3f8) into master (a19daa5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   20.20%   20.20%           
=======================================
  Files          20       20           
  Lines        1440     1440           
=======================================
  Hits          291      291           
  Misses       1149     1149           
Flag Coverage Δ
integration 5.90% <ø> (ø)
unittests 14.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcelRobitaille MarcelRobitaille force-pushed the 713-trim-multiple-whitespaces branch 2 times, most recently from 3210ddf to b441a87 Compare March 20, 2022 07:30
Fixes nextcloud#713

Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
@MarcelRobitaille MarcelRobitaille force-pushed the 713-trim-multiple-whitespaces branch from b441a87 to 9f6eab9 Compare March 20, 2022 07:33
@github-actions
Copy link

github-actions bot commented Mar 20, 2022

Unit Test Results

  20 files    20 suites   8m 0s ⏱️
  66 tests   66 ✔️ 0 💤 0
660 runs  660 ✔️ 0 💤 0

Results for commit 0eae3f8.

♻️ This comment has been updated with latest results.

@christianlupus christianlupus force-pushed the 713-trim-multiple-whitespaces branch from 9f6eab9 to 9903c69 Compare March 20, 2022 11:11
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to trim each line additionally. Let's have the example to paste:

   100 g     Reis
    50 ml    Wasser
     1 Prise Salz

This will cause a single space before the 2nd and 3rd row.

src/components/EditInputGroup.vue Outdated Show resolved Hide resolved
Signed-off-by: Marcel Robitaille <mail@marcelrobitaille.me>
@christianlupus christianlupus force-pushed the 713-trim-multiple-whitespaces branch from f359c44 to 0eae3f8 Compare March 20, 2022 17:51
Copy link
Collaborator

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. LGTM

@christianlupus christianlupus merged commit 5d4232c into nextcloud:master Mar 20, 2022
@MarcelRobitaille MarcelRobitaille deleted the 713-trim-multiple-whitespaces branch March 20, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple whitespaces should be trimmed when pasting
2 participants