Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that thumbnail file needs to be created if not yet existing #985

Merged
merged 3 commits into from
May 12, 2022

Conversation

christianlupus
Copy link
Collaborator

Adding an image to a recipe without image causes the thumbnail generator to throw an exception.

Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
Signed-off-by: Christian Wolf <github@christianwolf.email>
@christianlupus christianlupus requested a review from seyfeb May 11, 2022 20:05
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #985 (ab69e3a) into master (0108242) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   29.59%   29.68%   +0.09%     
==========================================
  Files          31       31              
  Lines        1561     1563       +2     
==========================================
+ Hits          462      464       +2     
  Misses       1099     1099              
Flag Coverage Δ
integration 5.43% <0.00%> (-0.01%) ⬇️
unittests 24.24% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/Helper/ImageService/ThumbnailFileHelper.php 97.05% <100.00%> (+0.18%) ⬆️

@github-actions
Copy link

Unit Test Results

     24 files       24 suites   8m 12s ⏱️
   122 tests    122 ✔️ 0 💤 0
1 464 runs  1 464 ✔️ 0 💤 0

Results for commit ab69e3a.

@christianlupus christianlupus merged commit 7b66a85 into master May 12, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/new-image-failure branch May 12, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants