Skip to content

Commit

Permalink
Fix inspection issues
Browse files Browse the repository at this point in the history
Signed-off-by: Julius Härtl <jus@bitgrid.net>
  • Loading branch information
juliusknorr committed Oct 10, 2017
1 parent 0936bb2 commit 9d10644
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
6 changes: 3 additions & 3 deletions lib/Service/BoardService.php
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,10 @@ public function create($title, $userId, $color) {
'F1DB50' => $this->l10n->t('Later')
];
$labels = [];
foreach ($default_labels as $color => $title) {
foreach ($default_labels as $labelColor => $labelTitle) {
$label = new Label();
$label->setColor($color);
$label->setTitle($title);
$label->setColor($labelColor);
$label->setTitle($labelTitle);
$label->setBoardId($new_board->getId());
$labels[] = $this->labelMapper->insert($label);
}
Expand Down
2 changes: 1 addition & 1 deletion lib/Service/PermissionService.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function getPermissions($boardId) {
/**
* Get current user permissions for a board
*
* @param Board $board
* @param Board|Entity $board
* @return array|bool
* @internal param $boardId
*/
Expand Down
12 changes: 10 additions & 2 deletions lib/Service/StackService.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,16 @@ class StackService {
private $labelMapper;
private $permissionService;
private $boardService;

public function __construct(StackMapper $stackMapper, CardMapper $cardMapper, LabelMapper $labelMapper, PermissionService $permissionService, BoardService $boardService, AssignedUsersMapper $assignedUsersMapper) {
private $assignedUsersMapper;

public function __construct(
StackMapper $stackMapper,
CardMapper $cardMapper,
LabelMapper $labelMapper,
PermissionService $permissionService,
BoardService $boardService,
AssignedUsersMapper $assignedUsersMapper
) {
$this->stackMapper = $stackMapper;
$this->cardMapper = $cardMapper;
$this->labelMapper = $labelMapper;
Expand Down

0 comments on commit 9d10644

Please sign in to comment.