Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS rule for blockquotes #2064

Closed
reox opened this issue Jun 24, 2020 · 4 comments · Fixed by #2065
Closed

CSS rule for blockquotes #2064

reox opened this issue Jun 24, 2020 · 4 comments · Fixed by #2065

Comments

@reox
Copy link
Contributor

reox commented Jun 24, 2020

Is your feature request related to a problem? Please describe.

The Markdown editor allows for quotes using >:

This is not a quote
> This is a quote

However, blockquotes are not rendered in markdown.

Describe the solution you'd like

Something like this:

image

this uses:

#description-preview blockquote {
    padding-left: 1em;
    border-left: 0.5ex solid black;
    font-style: italic;
}

Describe alternatives you've considered

There are plenty of quoting styles. Any style is fine as long as it can clearly be distinguished from normal text.

this is how a quote in github looks like

Additional context
v1.0.3

@stefan-niedermann
Copy link
Member

I would rather see the resources put in solving #1561 (which supports quoted texts) instead of messing around with the current editor 😄

If this issue pinches you hard, you may want to create a Pull Request and contribute a quickfix? 🙂 🚀

@reox
Copy link
Contributor Author

reox commented Jun 24, 2020

I would rather see the resources put in solving #1561 (which supports quoted texts) instead of messing around with the current editor smile

Did not knew that! Then, this one could be closed as duplicate I guess.

If this issue pinches you hard, you may want to create a Pull Request and contribute a quickfix? slightly_smiling_face rocket

The only thing I can offer is to push those changes in an untested branch :D
But I do not even know where I should put the CSS 😅
Does it belong somewhere here:

#description-preview {
min-height: 100px;
&::v-deep {
@import "./../../css/markdown";
}
&::v-deep input {
min-height: auto;
}
&::v-deep a {
text-decoration: underline;
}
}
?

@juliusknorr
Copy link
Member

This would be the right place actually: https://github.com/nextcloud/deck/blob/master/src/css/markdown.scss

Pull requests are very welcome :)

@reox
Copy link
Contributor Author

reox commented Jun 24, 2020

yeah I could do that ;) but as I said I can not really test it, as I do not have any test setup rolling ...

reox added a commit to reox/deck that referenced this issue Jun 24, 2020
Using a vertical bar next to the text to indicate a blockquote.
Using lighter text color as well (similar to github's blockquotes).

resolves nextcloud#2064

Signed-off-by: Sebastian Bachmann <hello@reox.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants