Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card-View: Duedate delete-Icon not aligned properly #3791

Closed
Ben-Ro opened this issue May 8, 2022 · 2 comments · Fixed by #3811
Closed

Card-View: Duedate delete-Icon not aligned properly #3791

Ben-Ro opened this issue May 8, 2022 · 2 comments · Fixed by #3811

Comments

@Ben-Ro
Copy link
Contributor

Ben-Ro commented May 8, 2022

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Describe the bug
When a Duedate is set, the Delete Icon isn't aligned properly but a bit tu much up. It should be within the yellow lines of the screenshot. Affects both the bigger card view and the default view.

To Reproduce
Steps to reproduce the behavior:

  1. Create a Card with Due Date
  2. Close and open the card to see the misaligned delete Icon (is this a complete other bug, imo the icon should appear directly after setting a duedate and not only after exiting and reopening)

Affected Versions
At least 1.6.1 up to git master

Expected behavior
The Icon should be within the yellow lines correctly aligned.

Screenshots
Bildschirmfoto 2022-05-08 um 20 01 copy
Bildschirmfoto 2022-05-08 um 20 01 56

Client details:

  • OS: macOS
  • Browser chrome, safari
  • Version Safari: 15.4 Chrome: 101
  • Device: Macbook Pro 13

Operating system: Debian 11

Web server: php -S, it's a frontend bug

Database: SQLITE

PHP version: 8.1

Nextcloud version: git-master

Where did you install Nextcloud from: git clone

Ben-Ro added a commit to Ben-Ro/deck that referenced this issue May 12, 2022
@Ben-Ro
Copy link
Contributor Author

Ben-Ro commented May 12, 2022

The misalignment annoyed me too much every time i looked at it, so i fixed it and created a Pull-Request. I hope thats fine :)

@juliusknorr
Copy link
Member

@Ben-Ro This is awesome, thanks a lot for that :)

juliusknorr added a commit that referenced this issue May 12, 2022
…t_aligned_properly

Align Duedate-delete icon properly - fixes #3791
backportbot-nextcloud bot pushed a commit that referenced this issue May 12, 2022
Signed-off-by: ben <ben@ro.tt>
backportbot-nextcloud bot pushed a commit that referenced this issue May 12, 2022
Signed-off-by: ben <ben@ro.tt>
backportbot-nextcloud bot pushed a commit that referenced this issue May 12, 2022
Signed-off-by: ben <ben@ro.tt>
juliusknorr added a commit that referenced this issue May 13, 2022
[stable24] Align Duedate-delete icon properly - fixes #3791
juliusknorr added a commit that referenced this issue May 13, 2022
[stable23] Align Duedate-delete icon properly - fixes #3791
juliusknorr added a commit that referenced this issue May 13, 2022
[stable22] Align Duedate-delete icon properly - fixes #3791
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants