Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleting boards and add a simple undo function #113

Merged
merged 1 commit into from
May 4, 2017
Merged

Fix deleting boards and add a simple undo function #113

merged 1 commit into from
May 4, 2017

Conversation

juliusknorr
Copy link
Member

Fix for #108 and #85 for boards only

Please test @himBeere @artemanufrij

@juliusknorr juliusknorr added this to the 0.1.4 milestone May 2, 2017
@artemanufrij
Copy link
Member

artemanufrij commented May 2, 2017 •
edited
Loading

@juliushaertl will do it when I'm back home :)

@codecov
Copy link

codecov bot commented May 2, 2017 •
edited
Loading

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   76.28%   76.28%           
=======================================
  Files          31       31           
  Lines         776      776           
=======================================
  Hits          592      592           
  Misses        184      184

@artemanufrij
Copy link
Member

artemanufrij commented May 2, 2017 •
edited
Loading

@juliushaertl
Deleting works as expected for me... And I can cancel it...

  • it's not possible to delete board instant... I have to wait for the time...

  • It's not really clear that you can cancel it by clicking timer label --> maybe a "stop" or "X" button...

@artemanufrij artemanufrij self-requested a review May 2, 2017 19:49
artemanufrij
artemanufrij reviewed May 2, 2017
View reviewed changes
Copy link
Member

@artemanufrij artemanufrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting works as expected for me... And I can cancel it...

it's not possible to delete board instant... I have to wait for the time...

It's not really clear that you can cancel it by clicking timer label --> maybe a "stop" or "X" button...

@juliusknorr
Copy link
Member Author

@artemanufrij Good point, I'll add a Stop text when hovering maybe.

@juliusknorr
Fix deleting boards and add a simple undo function
588252d 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the delete-fix-and-undo branch from 0ca7082 to 588252d Compare May 3, 2017 11:22
JSoko
JSoko reviewed May 3, 2017
View reviewed changes
Copy link
Member

@JSoko JSoko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting and editing boards works here again as it should with this pr

@juliusknorr juliusknorr merged commit c08455e into master May 4, 2017
@juliusknorr
Copy link
Member Author

Let's merge, since it fixes #108.

@juliusknorr juliusknorr deleted the delete-fix-and-undo branch May 4, 2017 06:37
This was referenced May 4, 2017
Closed
Closed
Closed
@wiertz wiertz mentioned this pull request Oct 27, 2020
Closed
This was referenced Mar 12, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSoko JSoko JSoko left review comments

@artemanufrij artemanufrij artemanufrij left review comments

Assignees
No one assigned
Labels
3. to review bug frontend regression
Projects
None yet
Milestone
0.1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @artemanufrij @JSoko