Remove deprecated global API calls #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
juliusknorr
force-pushed
the
bugfix/noid/deprecated-js-api
branch
from
bec3be9
to
a89529c
Compare
ChristophWurst
requested changes
Apr 27, 2020
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
bugfix/noid/deprecated-js-api
branch
from
a89529c
to
c940617
Compare
Codecov Report
@@ Coverage Diff @@
## master #1774 +/- ##
=======================================
Coverage 56.92% 56.92%
=======================================
Files 77 77
Lines 3842 3842
=======================================
Hits 2187 2187
Misses 1655 1655 |
ChristophWurst
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cleanup to make eslint complain less and have cleaner code 😉