Fix updating checkbox state and avoid issues due to duplicate sidebar element #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
…2580) Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
reviewed
Nov 19, 2020
| @@ -37,7 +37,7 @@ | |||
| </div> | |||
| </Modal> | |||
|
|
|||
| <router-view v-show="!cardDetailsInModal || !$route.params.cardId" name="sidebar" /> | |||
| <router-view name="sidebar" :visible="!cardDetailsInModal || !$route.params.cardId" /> | |||
There was a problem hiding this comment.
Can't use v-if directly on the router-view?
There was a problem hiding this comment.
There seems to be some issue with the nested router views that are used for sub-routes, where the router tried to render the component to a non-existing router-view element then. That is why I went that way for now. But I have that on my list to investigate further, so this is more a temporary workaround to fix the bug.
skjnldsv
approved these changes
Nov 19, 2020
This was referenced Nov 19, 2020
This was referenced Nov 19, 2020
|
A timely release would be awesome because of the accidental data loss happening with a wrong mouse click. |
This was referenced Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2580
Besides the fix for replacing the proper description this also required some adjustment to make sure that the actual card sidebar was not hidden in the DOM during editing in the modal.