Use async import for vue component on collections entrypoint #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Pytal
reviewed
Jul 8, 2021
| const SelectorView = Vue.extend(CardSelector) | ||
| const ComponentVM = new SelectorView({ | ||
| propsData: { | ||
| const CardSelector = () => import('./../CardSelector') |
There was a problem hiding this comment.
Suggested change
| const CardSelector = () => import('./../CardSelector') | |
| const CardSelector = () => import('../CardSelector') |
Pytal
approved these changes
Jul 8, 2021
|
can't merge due to "out-of-date" rule |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as in nextcloud/spreed#5974
Use async loading of the component that get triggered in the files app or the collections as otherwise the imports of dependent components from @nextcloud/vue takes up quite some time when loading the files app initially without triggering the display.