Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show both bullets and checkboxes for checklists #3327

Conversation

Themanwhosmellslikesugar
Copy link
Contributor

@Themanwhosmellslikesugar Themanwhosmellslikesugar commented Sep 17, 2021

Signed-off-by: Dmitriy Ivanko tmwsls12@gmail.com

Summary

I removed the markers from checkboxes, this is a hotfix, I would suggest making changes to markdown-it-task-lists or replacing it.

This is how it looks now:
image

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@Themanwhosmellslikesugar Themanwhosmellslikesugar marked this pull request as draft September 17, 2021 10:04
@Themanwhosmellslikesugar Themanwhosmellslikesugar marked this pull request as ready for review September 17, 2021 10:26
@juliusknorr
Copy link
Member

Thanks a lot for your contribution. Looks much better that way. Maybe you can also make the text aligned and the bullet points be centered compared to the checkboxes like the following?

image

@Themanwhosmellslikesugar
Copy link
Contributor Author

Thanks a lot for your contribution. Looks much better that way. Maybe you can also make the text aligned and the bullet points be centered compared to the checkboxes like the following?

image

Ok, I'll do it a bit later, but this week

@juliusknorr
Copy link
Member

@Themanwhosmellslikesugar Could you do a rebase to latest master instead of a merge so we have a clean git history? :)

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer 👍 Thanks a lot

@Themanwhosmellslikesugar
Copy link
Contributor Author

@Themanwhosmellslikesugar Could you do a rebase to latest master instead of a merge so we have a clean git history? :)

Did rebase instead of merge

Signed-off-by: Dmitriy Ivanko <tmwsls12@gmail.com>
Signed-off-by: Dmitriy Ivanko <tmwsls12@gmail.com>
@juliusknorr juliusknorr merged commit c72714f into nextcloud:master Oct 5, 2021
@Themanwhosmellslikesugar Themanwhosmellslikesugar deleted the fix/do-not-show-both-checkbox branch October 5, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Both bullets and checkboxes shown for checklists.
2 participants