Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show absolute dates when printing #3375

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Show absolute dates when printing #3375

merged 1 commit into from
Oct 12, 2021

Conversation

weeman1337
Copy link
Member

Summary

Show absolute dates when printing:

image

@@ -23,8 +23,9 @@
<template>
<div v-if="card" class="duedate">
<transition name="zoom">
<div v-if="card.duedate" :class="dueIcon">
<span>{{ relativeDate }}</span>
<div v-if="card.duedate" :class="dueIcon" :title="absoluteDate">
Copy link
Member Author

@weeman1337 weeman1337 Oct 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the title attribute. There was a dueDateTooltip computed property before. But it wasn't be used. This now shows the absolute date when hovering.

},
}
</script>

<style lang="scss" coped>
<style lang="scss" scoped>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo fixed

@weeman1337 weeman1337 force-pushed the enh/print-dates branch 2 times, most recently from 13cf7ed to 986f4ff Compare October 10, 2021 10:00
@stefan-niedermann
Copy link
Member

Just an idea, but to minimize DOM content and javascript logic, ine could utilize content: attr() to print the title attribute

relates to #3250

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337
Copy link
Member Author

Just an idea, but to minimize DOM content and javascript logic, ine could utilize content: attr() to print the title attribute

Great idea. I have implemented it this way 👍

@juliusknorr juliusknorr merged commit f051114 into master Oct 12, 2021
@juliusknorr juliusknorr deleted the enh/print-dates branch October 12, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants