Show board name in browser title #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luka-nextcloud
changed the title
juliusknorr
reviewed
Dec 29, 2021
src/components/Controls.vue
Outdated
| @@ -271,6 +271,8 @@ export default { | |||
| if (current?.id !== previous?.id) { | |||
| this.clearFilter() | |||
| } | |||
|
|
|||
| document.title = this.board.title | |||
There was a problem hiding this comment.
Please make sure to store the default page title like "Deck - Nextcloud" that is set and then only add the board title in front. You can find some inspiration on that in the Talk app: https://github.com/nextcloud/spreed/blob/master/src/App.vue#L418-L441
There was a problem hiding this comment.
Also if no board is set, it should then fall back tio the default one ;)
There was a problem hiding this comment.
Please check again. All fixed.
luka-nextcloud
force-pushed
the
feature/show-board-name-in-browser-title
branch
from
90448a6
to
fbf878f
Compare
luka-nextcloud
force-pushed
the
feature/show-board-name-in-browser-title
branch
from
fbf878f
to
c254a0e
Compare
juliusknorr
reviewed
Jan 11, 2022
src/components/Controls.vue
Outdated
| setPageTitle(title) { | ||
| if (this.defaultPageTitle === false) { | ||
| this.defaultPageTitle = window.document.title | ||
| if (this.defaultPageTitle.indexOf(' - ' + t('spreed', 'Deck') + ' - ') !== -1) { |
There was a problem hiding this comment.
Suggested change
| if (this.defaultPageTitle.indexOf(' - ' + t('spreed', 'Deck') + ' - ') !== -1) { | |
| if (this.defaultPageTitle.indexOf(' - Deck - ') !== -1) { |
The app name is currently not translated anywhere, so let's stick to that. Otherwise spreed would be the wrong app id here ;)
juliusknorr
reviewed
Jan 11, 2022
src/components/Controls.vue
Outdated
| if (this.defaultPageTitle === false) { | ||
| this.defaultPageTitle = window.document.title | ||
| if (this.defaultPageTitle.indexOf(' - ' + t('spreed', 'Deck') + ' - ') !== -1) { | ||
| this.defaultPageTitle = this.defaultPageTitle.substring(this.defaultPageTitle.indexOf(' - ' + t('spreed', 'Deck') + ' - ') + 3) |
There was a problem hiding this comment.
Suggested change
| this.defaultPageTitle = this.defaultPageTitle.substring(this.defaultPageTitle.indexOf(' - ' + t('spreed', 'Deck') + ' - ') + 3) | |
| this.defaultPageTitle = this.defaultPageTitle.substring(this.defaultPageTitle.indexOf(' - Deck - ') + 3) |
juliusknorr
reviewed
Jan 11, 2022
src/components/Controls.vue
Outdated
Comment on lines
346
to
347
| if (this.defaultPageTitle.indexOf(t('spreed', 'Deck') + ' - ') !== 0) { | ||
| this.defaultPageTitle = t('spreed', 'Deck') + ' - ' + this.defaultPageTitle |
There was a problem hiding this comment.
Suggested change
| if (this.defaultPageTitle.indexOf(t('spreed', 'Deck') + ' - ') !== 0) { | |
| this.defaultPageTitle = t('spreed', 'Deck') + ' - ' + this.defaultPageTitle | |
| if (this.defaultPageTitle.indexOf('Deck - ') !== 0) { | |
| this.defaultPageTitle = 'Deck - ' + this.defaultPageTitle |
Signed-off-by: Luka Trovic <luka@nextcloud.com>
luka-nextcloud
force-pushed
the
feature/show-board-name-in-browser-title
branch
from
c254a0e
to
b26f61b
Compare
juliusknorr
approved these changes
Jan 14, 2022
delete-merged-branch
bot
deleted the
feature/show-board-name-in-browser-title
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary
Now it shows the current board name in the browser title.
TODO
Checklist